Fix a couple of db.runCommand() issues #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There you go. I think that's better. |
mafintosh
added a commit
that referenced
this pull request
Aug 31, 2013
Fix a couple of db.runCommand() issues
|
Great stuff (as usual)! |
|
Thanks. |
|
Released as 0.8.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes 2 use cases of the
db.runCommand()that didn't work on mongojs. The first was to run a database command that doesn't receive a parameter such asdb.ping(). For example the following statementsAre equivalent in the mongo shell. The first worked in mongojs but the second didn't.
The other case was using a command that gets applied to a collection without parameters such as
These 2 lines are equivalent in the mongo shell but the first one didn't work on mongojs. This pull request fixes both this issues, adds a test case for each one and updates the docs accordingly.